Fix curl_close() deprecation in PHP 8.5#248
Open
kayw-geek wants to merge 1 commit intosegmentio:masterfrom
Open
Fix curl_close() deprecation in PHP 8.5#248kayw-geek wants to merge 1 commit intosegmentio:masterfrom
kayw-geek wants to merge 1 commit intosegmentio:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Hi @MichaelGHSeg, Could you please review it when you have time? |
Author
|
Hi @MichaelGHSeg, friendly bump on this one. I understand this library is in maintenance mode, and this PR fits squarely within that scope — it's not a new feature, it's a critical maintenance fix. PHP 8.5 has been out for months and For high-traffic applications, this floods logs with thousands of notices, which is exactly the kind of issue maintenance mode should address. The fix is a one-liner, zero risk, no behavioral change. Would really appreciate getting this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl_close()has no effect since PHP 8.0 (handles are nowCurlHandleobjects auto-closed by GC) and is formally deprecated in PHP 8.5curl_close()on PHP < 8.0 where handles are still resourcesTest plan
🤖 Generated with Claude Code